fix(files_sharing): Fix error messages from password policy #49361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exceptions thrown from password_policy may bubble up in share creation or update when a password is used. Their message is meant to be shown to the user. This always the case for HintException so we catch that instead of the subclass GenericShareException. Signed-off-by: Côme Chilliet <[email protected]>
come-nc
requested review from
provokateurin,
nickvergessen and
tobiasKaminsky
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable28 |
provokateurin
approved these changes
Nov 19, 2024
skjnldsv
approved these changes
Nov 19, 2024
2 tasks
|
I tested it with my Android test case and it still fails with generic error message. |
4 tasks
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable28 |
|
Requiring backports again now that #49366 is approved, both PR will need to be backported. |
This was referenced Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #48918
Summary
Exceptions thrown from password_policy may bubble up in share creation or update when a password is used. Their message is meant to be shown to the user. This always the case for HintException so we catch that instead of the subclass GenericShareException.
Checklist